Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename all to iter #600

Merged
merged 1 commit into from
May 30, 2021
Merged

Rename all to iter #600

merged 1 commit into from
May 30, 2021

Conversation

bugadani
Copy link
Member

Thank you for helping out with embedded-graphics development! Please:

  • Check that you've added passing tests and documentation
  • Add a CHANGELOG.md entry in the Unreleased section under the appropriate heading (Added, Fixed, etc) if your changes affect the public API
  • Run rustfmt on the project
  • Run just build (Linux/macOS only) and make sure it passes. If you use Windows, check that CI passes once you've opened the PR.

PR description

As discussed in #596 (comment)

@bugadani
Copy link
Member Author

@rfuest is the associated function used anywhere?

@rfuest
Copy link
Member

rfuest commented May 30, 2021

@rfuest is the associated function used anywhere?

Yes, but not in e-g itself. It's used in the new font conversion tool.

@rfuest
Copy link
Member

rfuest commented May 30, 2021

@jamwaffles How should we handle this breaking change? I don't think it requires a new beta release on its own, because only a very limited set of other crates will depend on this API.

@jamwaffles
Copy link
Member

I agree, I think it's fine to release it with other work. It's also trivial to update code to use the new name, so the impact is low for a breaking change.

Also, congratulations to us on 600 PRs/issues 🎉!

@bugadani
Copy link
Member Author

I'm a bit ashamed the 600th wasn't something bigger, to be honest 😅

@rfuest rfuest merged commit 488c601 into embedded-graphics:master May 30, 2021
@jamwaffles
Copy link
Member

I'll be posting people cake when we hit #1000 so make it worth it ;)

@bugadani bugadani deleted the iter branch May 30, 2021 17:25
@rfuest
Copy link
Member

rfuest commented May 30, 2021

I'll be posting people cake when we hit #1000 so make it worth it ;)

Don't tempt us or you'll need to review a lot of very small PRs in the near future 😉.

@bugadani
Copy link
Member Author

Nah I bet the cake is a lie.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants