-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump core to 0.3.2 #606
Bump core to 0.3.2 #606
Conversation
Co-authored-by: Ralf Fuest <mail@rfuest.de>
Thanks for the review :). I'll do a patch release of e-g when this PR is merged. Should I add you to the crate authors list so you can release stuff too? I think adding you to |
I wouldn't mind being included in the authors list and help with releasing stuff.
You would also need to give me owner permissions for crates.io: https://doc.rust-lang.org/cargo/reference/publishing.html#cargo-owner |
Ah ok, I thought crates.io picked it up from Cargo.toml but no worries. I'll add you to Also, would you prefer to be |
Released as 0.7.1. Just to note I had to do a |
Thanks. I think that these are all the crates we have released on crates.io, but with all the crates it's easy to miss some. There will be some unpublished crates, which only list one of us as author. Should we also update the authors in these crates or do should we not care about them because they will never be published on crates.io? I personally don't care too much about these. Would you also like me to give crates.io ownership to the core GH team when I release
I prefer to use my full name: |
That would be great, although I'm happy to leave you as sole owner if you'd like to retain control.
Nah I think it's fine to leave them as is, although worth checking to make sure they have As for crate owners, I've opened:
Please don't kick me out ;) |
No, I don't mind sharing control of all e-g related projects. Allowing multiple people to share the maintenance burden benefits the entire project IMO.
I'll try to remember that 😉 |
Thank you for helping out with embedded-graphics development! Please:
CHANGELOG.md
entry in the Unreleased section under the appropriate heading (Added, Fixed, etc) if your changes affect the public APIrustfmt
on the projectjust build
(Linux/macOS only) and make sure it passes. If you use Windows, check that CI passes once you've opened the PR.PR description
Bumps e-g core to minimum version 0.3.2.
Cc embedded-graphics/simulator#32