Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump core to 0.3.2 #606

Merged
merged 3 commits into from
Jun 15, 2021
Merged

Bump core to 0.3.2 #606

merged 3 commits into from
Jun 15, 2021

Conversation

jamwaffles
Copy link
Member

@jamwaffles jamwaffles commented Jun 15, 2021

Thank you for helping out with embedded-graphics development! Please:

  • Check that you've added passing tests and documentation
  • Add a CHANGELOG.md entry in the Unreleased section under the appropriate heading (Added, Fixed, etc) if your changes affect the public API
  • Run rustfmt on the project
  • Run just build (Linux/macOS only) and make sure it passes. If you use Windows, check that CI passes once you've opened the PR.

PR description

Bumps e-g core to minimum version 0.3.2.

Cc embedded-graphics/simulator#32

Cargo.toml Outdated Show resolved Hide resolved
Co-authored-by: Ralf Fuest <mail@rfuest.de>
@jamwaffles
Copy link
Member Author

Thanks for the review :). I'll do a patch release of e-g when this PR is merged.

Should I add you to the crate authors list so you can release stuff too? I think adding you to Cargo.toml is all that's required, right?

@rfuest
Copy link
Member

rfuest commented Jun 15, 2021

Should I add you to the crate authors list so you can release stuff too?

I wouldn't mind being included in the authors list and help with releasing stuff.

I think adding you to Cargo.toml is all that's required, right?

You would also need to give me owner permissions for crates.io: https://doc.rust-lang.org/cargo/reference/publishing.html#cargo-owner
The ownership can also be given to a github team, which I have previously done for bdf-parser: grafik
https://crates.io/crates/bdf-parser

@jamwaffles
Copy link
Member Author

Ah ok, I thought crates.io picked it up from Cargo.toml but no worries.

I'll add you to embedded-graphics, embedded-graphics-core, embedded-graphics-simulator, tinytga and tinybmp in a few PRs this evening/when I get round to it. Are there any others you'd like to be added to?

Also, would you prefer to be Ralf Fuest <mail@rfuest.de> in cargo.toml or just rfuest <mail@rfuest.de>?

@jamwaffles jamwaffles merged commit c08d832 into master Jun 15, 2021
@jamwaffles jamwaffles deleted the bump-core-version branch June 15, 2021 14:29
@jamwaffles
Copy link
Member Author

Released as 0.7.1. Just to note I had to do a cargo update in tools/generate-drawing-examples to make just build pass but nothing changed in the repo so I think we're all good.

@rfuest
Copy link
Member

rfuest commented Jun 15, 2021

I'll add you to embedded-graphics, embedded-graphics-core, embedded-graphics-simulator, tinytga and tinybmp in a few PRs this evening/when I get round to it. Are there any others you'd like to be added to?

Thanks. I think that these are all the crates we have released on crates.io, but with all the crates it's easy to miss some.

There will be some unpublished crates, which only list one of us as author. Should we also update the authors in these crates or do should we not care about them because they will never be published on crates.io? I personally don't care too much about these.

Would you also like me to give crates.io ownership to the core GH team when I release eg-bdf and eg-seven-segment?

Also, would you prefer to be Ralf Fuest <mail@rfuest.de> in cargo.toml or just rfuest <mail@rfuest.de>?

I prefer to use my full name: Ralf Fuest <mail@rfuest.de>

@jamwaffles
Copy link
Member Author

jamwaffles commented Jun 15, 2021

Would you also like me to give crates.io ownership to the core GH team when I release eg-bdf and eg-seven-segment?

That would be great, although I'm happy to leave you as sole owner if you'd like to retain control.

Should we also update the authors in these crates or do should we not care about them because they will never be published on crates.io? I personally don't care too much about these.

Nah I think it's fine to leave them as is, although worth checking to make sure they have publish = false on all of them.

As for crate owners, I've opened:

Please don't kick me out ;)

@rfuest
Copy link
Member

rfuest commented Jun 15, 2021

That would be great, although I'm happy to leave you as sole owner if you'd like to retain control.

No, I don't mind sharing control of all e-g related projects. Allowing multiple people to share the maintenance burden benefits the entire project IMO.

Please don't kick me out ;)

I'll try to remember that 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants