Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ImagePixelGetter trait #612

Merged
merged 1 commit into from
Sep 2, 2022
Merged

Conversation

rfuest
Copy link
Member

@rfuest rfuest commented Jun 28, 2021

This PR adds an ImagePixelGetter trait which can optionally be implemented by ImageDrawables to allow access to the pixel data.

@rfuest rfuest closed this Dec 21, 2021
@jamwaffles jamwaffles reopened this Dec 22, 2021
@rfuest rfuest mentioned this pull request Apr 24, 2022
6 tasks
Copy link
Member

@jamwaffles jamwaffles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Over a year old... apologies.

Not sure if this closes #609 as that issue mentions iterators.

@rfuest
Copy link
Member Author

rfuest commented Sep 2, 2022

Over a year old... apologies.

Don't worry, I would have bugged you earlier when this would have been important.

Not sure if this closes #609 as that issue mentions iterators.

Iterators are a separate issue IMO. The pixel getter can be used as a replacement, but wouldn't be as efficient if you need to iterate over all pixels.

@rfuest rfuest merged commit 8b4bc51 into embedded-graphics:master Sep 2, 2022
@rfuest rfuest deleted the image-pixels branch September 2, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants