Fix invalid MonoStyle text dimensions calculation #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch, thanks for fixing this. There is another use of Could you also add a unit test for the invalid bounding box? You can simply copy |
|
I'll look into it this weekend! |
derchr
force-pushed
the
work/text-fix
branch
2 times, most recently
from
c303e2b
to
0f31213
Compare
|
I also changed the calculation in the |
jamwaffles
approved these changes
Feb 10, 2022
There was a problem hiding this comment.
LGTM, thanks for the fix! I'll let @rfuest merge this in case there's anything else he'd like to see.
|
Looks good! The only thing that is missing is an entry in CHANGELOG.md. |
The method len() on &str does return the number of bytes of a character, not the number of characters. Using characters such as '°' (which are multiple bytes long) caused an incorrect calculation of the text bounding box. This commit fixes this by calling .chars().count() on &str. Also, a test was added to prevent false dimension calculations of multi-byte character strings in the future.
rfuest
force-pushed
the
work/text-fix
branch
from
cb88948
to
842bf87
Compare
|
Merged. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method len() on &str does return the number of bytes of a character.
Using characters such as '°' (which are two bytes long) caused an
incorrect calculation of the text bounding box.