Faster color conversions (Part 2) #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamwaffles
approved these changes
Feb 20, 2022
Great, thanks for verifying the result. I hadn't expected such a big improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a small addition to #651. Color conversions between color types that share some channel bit depths, like
Rgb565andRgb555, will now only calculate the conversion for the channels with different bit depths. The effect of this change was minimal to non existing on my desktop, but I think it can't hurt to add it. The compiler seems to already optimize away some redundant calculations now thatconvert_channeluses const generics instead of parameters.I've also added benches for the color conversions. Here is a comparison from before #651 and after this PR:
Note that
Rgb888toGray8doesn't use any of the code that was modified in the recent PRs and is only included for completeness.