-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add conversion from Rgb666 and Bgr666 to Grey8 #656
Add conversion from Rgb666 and Bgr666 to Grey8 #656
Conversation
This is required for the tinytga library. Fixes embedded-graphics#654.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I'll let @rfuest merge in case I missed anything with the colour conversion code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change itself looks good, but there are other instances in the same file where Rgb666
and Bgr666
are also missing. At least the gray_to_rgb
and rgb_to_gray
should be fixed before this gets merged.
The impl_from_binary!
and impl_rgb_to_binary!
and their test are also missing the Rgb666
and Bgr666
types. But if you don't want to fix these now, because they are outside the scope of this PR, we can fix these later.
I am totally unfamiliar with this code, so not surprising if I missed something. Looks like I missed updating the tests. Tests are good. Now fixed. Hopefully. |
For some reason the CI is unahppy with my new references to This is something I might need help with. |
Maybe you forgot to commit something? |
f288b36
to
aeb68a8
Compare
I missed those places. Now fixed. Odd this didn't break the tests when I ran them locally. |
Tests pass now. |
Did you run the tests by calling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two remaining issues:
Rgb666
andBgr666
are missing in thergb_to_rgb
test (line 220)- Please add a changelog entry to
/CHANGELOG.md
and/core/CHANGELOG.md
aeb68a8
to
9163c8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Can do this now embedded-graphics/embedded-graphics#656 was merged.
This is required for the tinytga library.
Fixes #654.