Make some more methods and functions const #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfuest
reviewed
Sep 2, 2022
jamwaffles
commented
Sep 2, 2022
jamwaffles
force-pushed
the
more-const-fn
branch
2 times, most recently
from
53b38c6
to
7650738
Compare
rfuest
requested changes
Sep 2, 2022
jamwaffles
force-pushed
the
more-const-fn
branch
from
7650738
to
357cf23
Compare
jamwaffles
force-pushed
the
more-const-fn
branch
from
357cf23
to
9ed205d
Compare
rfuest
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for helping out with embedded-graphics development! Please:
CHANGELOG.mdentry in the Unreleased section under the appropriate heading (Added, Fixed, etc) if your changes affect the public APIrustfmton the projectjust build(Linux/macOS only) and make sure it passes. If you use Windows, check that CI passes once you've opened the PR.PR description
A pass of
#![warn(clippy::missing_const_for_fn)]+cargo clippy.Doesn't do as much as I had hoped, but we still get some nice improvements. Notably,
PrimitiveStyleBuilderis now completelyconstwhich is great.Closes #674
TODO
const-ifications for changelog entry.