Make MonoTextStyleBuilder fns const
#730
Conversation
|
I guess technically this is a breaking change as the PR doesn't allow nonsense, half-finished builders that have a non-PixelColor type parameter. So technically, the PR can break code that wasn't ever meant to be working anyway, IMO. Any throughts on this? |
|
Not so sure I can comment on the correctness of this...but it would be great, so we're able to define styles as consts and use them throughout our program instead of having to rebuild them on every call to a display. |
src/mono_font/mono_text_style.rs
Outdated
| @@ -530,6 +524,11 @@ mod tests { | |||
| ..FONT_6X9 | |||
| }; | |||
|
|
|||
| const _CAN_BUILD_CONST: MonoTextStyle<'static, BinaryColor> = MonoTextStyleBuilder::new() | |||
There was a problem hiding this comment.
I'd probably move that to a test fn
There was a problem hiding this comment.
It would be the same thing, just with more lines, and it would also create a test that asserts nothing, and does nothing except print that it passes. Would it really be better?
There was a problem hiding this comment.
personal preference: either test fn or remove entirely - it's just a showcase, right? Either way no strong feelings
bugadani
force-pushed
the
const
branch
3 times, most recently
from
5896a43
to
12b4b28
Compare
|
Sorry for not going with your suggestion directly, but there were other bounds to move, too. |
Thank you for helping out with embedded-graphics development! Please:
CHANGELOG.mdentry in the Unreleased section under the appropriate heading (Added, Fixed, etc) if your changes affect the public APIrustfmton the projectjust build(Linux/macOS only) and make sure it passes. If you use Windows, check that CI passes once you've opened the PR.PR description
[add your PR description here]
cc #205