Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update editor example #136

Merged
merged 20 commits into from
Aug 7, 2021
Merged

Update editor example #136

merged 20 commits into from
Aug 7, 2021

Conversation

bugadani
Copy link
Member

@bugadani bugadani commented Jul 11, 2021

The goal of this PR is to improve the editor example to support vertical cursor movement.

  • Words longer than a line are handled incorrectly. Might be an issue on line boundaries?
  • There may or may not still be a small disagreement between the offsets with multiple empty lines.
  • Click to move cursor
  • Move displayed area if cursor moves out of view - coordinate based.
    Needs to track if cursor is at the end of line. Alternative is a one-frame delay.
  • Move displayed area if cursor moves out of view - character offset based.
    Needs to specify that cursor coordinates are in "text space". Also, need to define "text space" vs "world space".
  • Allow accessing plugins after drawing, remove Rc from plugin

@bugadani bugadani force-pushed the cursor branch 11 times, most recently from ff6a10f to 0a157be Compare July 17, 2021 20:22
@bugadani bugadani force-pushed the cursor branch 2 times, most recently from 26db23a to 02d9bd4 Compare July 28, 2021 09:12
@bugadani bugadani marked this pull request as ready for review August 7, 2021 16:02
@bugadani bugadani merged commit 2f88bbf into master Aug 7, 2021
@bugadani bugadani deleted the cursor branch August 7, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant