Update to new e-g alpha #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
force-pushed
the
iface
branch
5 times, most recently
from
cec258d
to
707cb0e
Compare
16 tasks
rfuest
reviewed
Jan 11, 2021
| @@ -257,7 +274,7 @@ pub struct TextBoxStyle<C, F, A, V, H> { | |||
| pub line_spacing: i32, | |||
There was a problem hiding this comment.
Is this parameter the spacing between the bounding boxes of two adjacent lines or the difference in the baseline position? I did plan to add a line_height: u32 parameter to TextStyle and I think we should use the same in e-g and e-t.
There was a problem hiding this comment.
Right now it's the space between 2 bounding boxes, but probably should be the other one.
4 tasks
bugadani
force-pushed
the
iface
branch
2 times, most recently
from
f835f1b
to
cb7bb86
Compare
bugadani
force-pushed
the
iface
branch
3 times, most recently
from
e93f13c
to
df3b996
Compare
bugadani
changed the title
bugadani
force-pushed
the
iface
branch
14 times, most recently
from
c044de9
to
c9cf566
Compare
bugadani
force-pushed
the
iface
branch
2 times, most recently
from
cf504b2
to
a1f0ce5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR started with the goal to define a common text renderer interface. Now that has been done in embedded-graphics. This PR implements the necessary changes to work with the new text renderer API provided by embedded-graphics. And then a lot of internal (and not so internal) refactors. Oh well.
Closes #85