Add embedded-text example #13
Conversation
eg-next/README.md
Outdated
| @@ -76,3 +76,8 @@ | |||
|
|
|||
| [](examples/text-transparent.rs) | |||
|
|
|||
|
|
|||
| ## [textbox-alignment](examples/textbox-alignment.rs) | |||
There was a problem hiding this comment.
I'm not sure about the name of the demo. I would like to use the text- prefix, because it is a text related feature and contain embedded-text, because it is a demo for that external create. But text-embedded-text doesn't sound great either.
There was a problem hiding this comment.
text-basic-layout is the best I can come up with
There was a problem hiding this comment.
I was considering merging the example into text-multiline or text-alignment and I didn't like either option. Truth is, this example is a bit of both.
I'm afraid that users would miss the fact the example uses an "external" crate if we keep the names so similar.
There was a problem hiding this comment.
Maybe text-textbox?
In the future we could update the README.md to include sections and maybe some description per example. But for now we should just pick any of the suggested names. This can easily be improved later without breaking anything.
There was a problem hiding this comment.
text-textbox seems good enough. Since there exists a single example right now, I've used this name. Later this might turn into a prefix.
We might also use something like text-advanced-... in the future, maybe.
eg-next/README.md
Outdated
| @@ -76,3 +76,7 @@ | |||
|
|
|||
| [](examples/text-transparent.rs) | |||
|
|
|||
| ## [text-textbox](examples/text-textbox.rs) | |||
|
|
|||
| [](examples/text-textbox.rs) | |||
There was a problem hiding this comment.
I guess you didn't use just generate-readmes to generate this file? I don't think it's checked by CI at the moment, but could lead to problems in the future.
There was a problem hiding this comment.
Nah, I'm just using windows ^^. Is there something wrong here? Ah I see, there's a template.
There was a problem hiding this comment.
If you have allowed edits by maintainers I can run the script if you like.
There was a problem hiding this comment.
Honestly, I'd prefer not generating the alt texts. Allow edits is on by default.
|
I added the I also just noticed CircleCI didn't have the "Build forked pull requests" option turned on, which I've now enabled. |
Great, I was wondering why CI didn't work. |
|
Aww yessssss, e-t is MSRV 1.43. |
|
A forgot that e-t has a newer MSRV than e-g. Should we just disable the 1.40.0 build? I honestly don't care about 1.40.0 compatibility anymore and would like to change the MSRV policy as soon as 0.7 is released. |
|
I'd be happy to bump the MSRV too as I'm also not that bothered by it. Would we be ok just bumping to 1.43 for now and opening an issue in e-g to discuss what the new version/policy should be? |
|
I think examples are fine on stable only. MSRV is that - minimum supported, the crates can stay as low as they can/want IMO. |
|
We will also need to consider I agree with @bugadani in that we should just require the latest stable version for the examples to keep this simple. |
|
Sounds good to me! Shall I attach that change to #14 ? |
Yes, why not. Do you want to merge this PR in a semi broken state for now? |
There's no rush on this one |
|
I just merged #14 so this PR should pass its build once rebased. |
Co-authored-by: Ralf Fuest <mail@rfuest.de>
|
Sweet! |
This is just the simplest possible example I could think of, that would otherwise be annoying to do in embedded-graphics. Surprisingly, things seem to work :)
Progress towards #8