Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for strnstr #5

Closed
phillipjohnston opened this issue Oct 18, 2017 · 5 comments
Closed

Add unit test for strnstr #5

phillipjohnston opened this issue Oct 18, 2017 · 5 comments

Comments

@phillipjohnston
Copy link
Member

No description provided.

@seekaddo
Copy link
Collaborator

seekaddo commented Jan 3, 2018

I want to start working on some of the test issues. Can you please point me to some good reference or examples. For now I am learning from this

@phillipjohnston
Copy link
Member Author

That website is helpful, and you can also look into the test directory in the repository, which has test examples for other functions. Many of the existing tests were imported from an old 'libc-test' repository I found on the web.

I've provided some tips for adding new tests to the CONTRIBUTING guide as well.

I'm not sure what OS you are using, but there may be a linker problem with CMocka - I only have an OSX static library included at the moment. If that's a problem I'll look into a fix.

@seekaddo
Copy link
Collaborator

seekaddo commented Jan 3, 2018

@phillipjohnston I have using Max osx sierra and I have install cmocka. Its able to link with my Clion IDE without a problem. I and I have tried a few things here on Travis also. It works well. Take a look here even on mac osx travis builds ok here. Just with home brew and all was good.

@seekaddo
Copy link
Collaborator

seekaddo commented Jan 3, 2018

Thanks for the tipps, I will look into the test examples on CONTRIBUTING guide.

@seekaddo seekaddo self-assigned this Jan 5, 2018
@seekaddo
Copy link
Collaborator

seekaddo commented Mar 1, 2018

@phillipjohnston
cmocka is not working when i am trying to build the whole test project. I don't know if is having conflicts with my cmock 1.1 installed on mac osx. But when i build with cmake on my mac as a standalone function it works. I have to figure out a way to build it with the whole project otherwise i can just push it and see the build results from the CI/Jenkins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants