Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MalteseNewsClassification added #546

Merged
merged 11 commits into from
May 18, 2024
Merged

Conversation

dokato
Copy link
Collaborator

@dokato dokato commented Apr 24, 2024

Maltese news classification dataset: https://huggingface.co/datasets/MLRS/maltese_news_categories

As suggested here: #419

Checklist for adding MMTEB dataset

Reason for dataset addition:

  • I have tested that the dataset runs with the mteb package.
  • I have run the following models on the task (adding the results to the pr). These can be run using the mteb run -m {model_name} -t {task_name} command.
    • sentence-transformers/paraphrase-multilingual-MiniLM-L12-v2
    • intfloat/multilingual-e5-small
  • I have checked that the performance is neither trivial (both models gain close to perfect scores) nor random (both models gain close to random scores).
  • If the dataset is too big (e.g. >2048 examples), considering using self.stratified_subsampling() under dataset_transform()
  • I have filled out the metadata object in the dataset file (find documentation on it here).
  • Run tests locally to make sure nothing is broken using make test.
  • Run the formatter to format the code using make lint.
  • I have added points for my submission to the points folder using the PR number as the filename (e.g. 438.jsonl).

Copy link
Collaborator

@isaac-chung isaac-chung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a multilabel dataset. Let's keep it that way, and wait for #440 to merge before proceeding. Metadata looks good otherwise, and still requires linting.

@isaac-chung isaac-chung self-assigned this Apr 24, 2024
@dokato
Copy link
Collaborator Author

dokato commented Apr 24, 2024

Yup, that makes, sense, thanks @isaac-chung , I'll keep an eye on this pr!

@isaac-chung
Copy link
Collaborator

It's merged :)

@dokato
Copy link
Collaborator Author

dokato commented May 15, 2024

thanks @isaac-chung , yeah I saw, but as this is quite big, we're still trying to figure how to do stratified sampling for multilabel problem, see: #698
I proposed here my take on that, until I'll get a green light or alternative, let's keep it WIP.

@dokato dokato added the WIP Work In Progress label May 15, 2024
@x-tabdeveloping
Copy link
Contributor

@dokato Let's keep this in a separate PR so we can discuss the two things on different threads (this task and then stratified subsampling). It should also be fine considering that a) all of these models will be rerun anyway b) we already have a function that does this, maybe faulty, but the interface already exists and we can swap it out anytime

@dokato dokato removed the WIP Work In Progress label May 17, 2024
@dokato
Copy link
Collaborator Author

dokato commented May 17, 2024

K, done that! Created new PR in #760

This should be ready @isaac-chung. I "unwiped" it.

Copy link
Collaborator

@isaac-chung isaac-chung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for adding this!

@isaac-chung isaac-chung enabled auto-merge (squash) May 18, 2024 07:04
@isaac-chung isaac-chung merged commit 5314bf5 into embeddings-benchmark:main May 18, 2024
7 checks passed
@dokato dokato deleted the mlt-news branch May 20, 2024 08:30
dokato added a commit to dokato/mteb that referenced this pull request May 24, 2024
* MalteseNewsClassification added

* lint fixes

* MalteseNewsClassification as multilabel + WIP stratification added

* results for multilabel classfication updated

* Maltese MultiLabelClassification added

---------

Co-authored-by: Isaac Chung <chungisaac1217@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants