Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add JaGovFaqs and NLPJournal datasets #808

Merged

Conversation

awinml
Copy link
Contributor

@awinml awinml commented May 24, 2024

Checklist for adding MMTEB dataset

Part of #749

Changes Made:

Adds five Japanese Retrieval datasets:

  1. JaGovFaqs
  2. NLP Journal title-abs
  3. NLP Journal title-intro
  4. NLP Journal abs-intro

  • I have tested that the dataset runs with the mteb package.
  • I have run the following models on the task (adding the results to the pr). These can be run using the mteb -m {model_name} -t {task_name} command.
    • sentence-transformers/paraphrase-multilingual-MiniLM-L12-v2
    • intfloat/multilingual-e5-small
  • I have checked that the performance is neither trivial (both models gain close to perfect scores) nor random (both models gain close to random scores).
  • If the dataset is too big (e.g. >2048 examples), considering using self.stratified_subsampling() under dataset_transform()
  • I have filled out the metadata object in the dataset file (find documentation on it here).
  • Run tests locally to make sure nothing is broken using make test.
  • Run the formatter to format the code using make lint.
  • I have added points for my submission to the points folder using the PR number as the filename (e.g. 438.jsonl).

@awinml awinml mentioned this pull request May 24, 2024
Copy link
Contributor

@KennethEnevoldsen KennethEnevoldsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we will have to look into JAQKET otherwise things are looking good.

@awinml awinml changed the title fix: Add JaGovFaqs, JAQKET and NLPJournal datasets fix: Add JaGovFaqs and NLPJournal datasets Jun 16, 2024
@KennethEnevoldsen KennethEnevoldsen changed the base branch from main to addJMTEB June 17, 2024 07:22
@KennethEnevoldsen KennethEnevoldsen merged commit 52001eb into embeddings-benchmark:addJMTEB Jun 17, 2024
5 of 7 checks passed
@KennethEnevoldsen KennethEnevoldsen mentioned this pull request Jun 17, 2024
KennethEnevoldsen added a commit that referenced this pull request Jun 17, 2024
* fix: correct label for sib200

* fix: Add JaGovFaqs and NLPJournal datasets (#808)

* Add JaGovFaqs dataset

* Add NLPJournal datasets

* Add JAQKET dataset

* Add points

* Fix metadata

* Remove title from corpus for JAQKET dataset

* Update JAQKET scores (without title)

* Exclude JAQKET dataset

* Add points for review

---------

Co-authored-by: Ashwin Mathur <97467100+awinml@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants