Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NollySenti Bitext Mining (MINERS) #915

Merged

Conversation

gentaiscool
Copy link
Contributor

@gentaiscool gentaiscool commented Jun 13, 2024

NollySenti is Nollywood movie reviews for five languages widely spoken in Nigeria (English, Hausa, Igbo, Nigerian-Pidgin, and Yoruba.

Checklist

  • Run tests locally to make sure nothing is broken using make test.
  • Run the formatter to format the code using make lint.

Adding datasets checklist

Reason for dataset addition: ...

  • I have run the following models on the task (adding the results to the pr). These can be run using the mteb -m {model_name} -t {task_name} command.
    • sentence-transformers/paraphrase-multilingual-MiniLM-L12-v2
    • intfloat/multilingual-e5-small
  • I have checked that the performance is neither trivial (both models gain close to perfect scores) nor random (both models gain close to random scores).
  • If the dataset is too big (e.g. >2048 examples), considering using self.stratified_subsampling() under dataset_transform()
  • I have filled out the metadata object in the dataset file (find documentation on it here).
  • Run tests locally to make sure nothing is broken using make test.
  • Run the formatter to format the code using make lint.

@gentaiscool gentaiscool mentioned this pull request Jun 13, 2024
@gentaiscool
Copy link
Contributor Author

@KennethEnevoldsen I created a new PR for NollySenti.

@gentaiscool
Copy link
Contributor Author

I have completed the checklist @KennethEnevoldsen.

Copy link
Contributor

@KennethEnevoldsen KennethEnevoldsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will you add points and push models results as well?

}
""",
n_samples={"train": 1640},
avg_character_length={"train": 4.46},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a bit short?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the avg character length per sample (previously I put the avg char per word)

@gentaiscool
Copy link
Contributor Author

Thank you for the review. I addressed them. I updated the avg number of character per sample, added the results, and points. The new languages are hau-Latn, ibo-Latn, pcm-Latn, yor-Latn, so the points are 2 + 4 x 4 = 18. Plus, I added the point for the reviewer. @KennethEnevoldsen

@KennethEnevoldsen KennethEnevoldsen merged commit df68f8c into embeddings-benchmark:main Jun 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants