Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempted to call .send() with the action 'afterTransition' on the destroyed object liquid-container #616

Closed
thagul opened this issue Jul 4, 2018 · 7 comments

Comments

@thagul
Copy link

thagul commented Jul 4, 2018

After upgrading my application to ember.js v3.2.0, I see some tests failing with the error Attempted to call .send() with the action 'afterTransition' on the destroyed object liquid-container.

I've tried also to upgrade liquid-fire to ember.js 3.2.0 and the same error occurs

not ok 190 Chrome 66.0 - Global error: Uncaught Error: Assertion Failed: Attempted to call .send() with the action 'afterTransition' on the destroyed object '<dummy@component:liquid-container::ember4449>'. at http://localhost:7357/assets/vendor.js, line 52555
    ---
        Log: |
            { type: 'error',
              text: 'Uncaught Error: Assertion Failed: Attempted to call .send() with the action \'afterTransition\' on the destroyed object \'<dummy@component:liquid-container::ember4449>\'. at http://localhost:7357/assets/vendor.js, line 52555\n' }
    ...
not ok 191 Chrome 66.0 - Integration: liquid-outlet: it should support `use` option
    ---
        actual: >
            null
        stack: >
            http://localhost:7357/assets/vendor.js:52555
        message: >
            Uncaught Error: Assertion Failed: Attempted to call .send() with the action 'afterTransition' on the destroyed object '<dummy@component:liquid-container::ember4449>'.
        Log: |
    ...

I suppose that it's due to emberjs/ember.js#16387

@john-griffin
Copy link

Also just hit this.

@john-griffin
Copy link

john-griffin commented Jul 5, 2018

I was able to get around this problem by making sure the project had 0.7.25 of @ember/test-helpers. Our project uses yarn and was locked to an earlier version that does not play nicely with ember 3.2. So I removed the relevant lines from the lock file and regenerated.

I have submitted a PR to ember-qunit to resolve this emberjs/ember-qunit#331

@thagul are you able to confirm this fixes things for you?

@thagul
Copy link
Author

thagul commented Jul 6, 2018

I'm using ember 3.2 not 2.3, but I confirm that updating test-helpers to 0.7.25 solves the issue.

@john-griffin
Copy link

Sorry I meant 3.2 (have edited above), thanks for confirming, can you please close the issue?

@thagul
Copy link
Author

thagul commented Jul 6, 2018

Yes, sure.
See #616 (comment) for solution

@mike-north
Copy link

Can we

  1. reopen this so developers can find this as they attempt to upgrade
  2. detect incompatible (or insufficient?) versions of @ember/test-helpers and provide some sort of helpful feedback

@john-griffin
Copy link

This is effecting more than the liquid fire project so it seems like this might be an oversight in ember core/cli. Upgrading to 3.2 should be a compatible upgrade. Not sure each addon should need to handle this breaking of compatibility, we need to resolve this in the next ember-cli patch release with a new release of ember-qunit and ember-cli-qunit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants