Adding support for checking for next too.

ember-best-practices · Jun 26, 2017 · 233596b · 233596b
1 parent d1a42cd
commit 233596b
Show file tree

Hide file tree

Showing 2 changed files with 118 additions and 8 deletions.
diff --git a/lib/rules/require-ember-lifeline.js b/lib/rules/require-ember-lifeline.js
@@ -7,8 +7,8 @@ const { getEmberImportBinding } = require('../utils/imports');
 const { collectObjectPatternBindings } = require('../utils/destructed-binding');
 
 let DISALLOWED_OBJECTS = ['Ember.run', 'run'];
-let RUN_METHODS = ['later', 'debounce', 'throttle'];
-const LIFELINE_METHODS = ['runTask', 'debounceTask', 'throttleTask'];
+let RUN_METHODS = ['later', 'next', 'debounce', 'throttle'];
+const LIFELINE_METHODS = ['runTask', 'runTask', 'debounceTask', 'throttleTask'];
 
 function getMessage(actualMethodUsed) {
   let method = actualMethodUsed.split('.').pop();

diff --git a/tests/lib/rules/require-ember-lifeline.js b/tests/lib/rules/require-ember-lifeline.js
@@ -103,7 +103,7 @@ ruleTester.run('require-ember-lifeline', rule, {
           init() {
             Ember.run.later(() => {
               doSomeWork();
-            });
+            }, 100);
           }
         });`,
       parserOptions,
@@ -120,7 +120,7 @@ ruleTester.run('require-ember-lifeline', rule, {
             foo() {
               Ember.run.later(() => {
                 doSomeWork();
-              });
+              }, 100);
             }
           }
         });`,
@@ -137,7 +137,7 @@ ruleTester.run('require-ember-lifeline', rule, {
           init() {
             run.later(() => {
               doSomeWork();
-            });
+            }, 100);
           }
         });`,
       parserOptions,
@@ -154,7 +154,7 @@ ruleTester.run('require-ember-lifeline', rule, {
             foo() {
               run.later(() => {
                 doSomeWork();
-              });
+              }, 100);
             }
           }
         });`,
@@ -175,7 +175,7 @@ ruleTester.run('require-ember-lifeline', rule, {
           init() {
             foo.later(() => {
               doSomeWork();
-            });
+            }, 100);
           }
         });`,
       parserOptions,
@@ -196,7 +196,7 @@ ruleTester.run('require-ember-lifeline', rule, {
             bar() {
               foo.later(() => {
                 doSomeWork();
-              });
+              }, 100);
             }
           }
         });`,
@@ -209,6 +209,116 @@ ruleTester.run('require-ember-lifeline', rule, {
       code: `
         import Ember from 'ember';
 
+        export default Ember.Component({
+          init() {
+            Ember.run.next(() => {
+              doSomeWork();
+            });
+          }
+        });`,
+      parserOptions,
+      errors: [{
+        message: getMessage('Ember.run.next')
+      }]
+    },
+    {
+      code: `        
+        import Ember from 'ember';
+
+        export default Ember.Component({
+          actions: {
+            foo() {
+              Ember.run.next(() => {
+                doSomeWork();
+              });
+            }
+          }
+        });`,
+      parserOptions,
+      errors: [{
+        message: getMessage('Ember.run.next')
+      }]
+    },
+    {
+      code: `
+        import Ember from 'ember';
+
+        export default Ember.Component({
+          init() {
+            run.next(() => {
+              doSomeWork();
+            });
+          }
+        });`,
+      parserOptions,
+      errors: [{
+        message: getMessage('run.next')
+      }]
+    },
+    {
+      code: `
+        import Ember from 'ember';
+
+        export default Ember.Component({
+          actions: {
+            foo() {
+              run.next(() => {
+                doSomeWork();
+              });
+            }
+          }
+        });`,
+      parserOptions,
+      errors: [{
+        message: getMessage('run.next')
+      }]
+    },
+    {
+      code: `
+        import Ember from 'ember';
+
+        const {
+          run: foo
+        } = Ember;
+
+        export default Ember.Component({
+          init() {
+            foo.next(() => {
+              doSomeWork();
+            });
+          }
+        });`,
+      parserOptions,
+      errors: [{
+        message: getMessage('foo.next')
+      }]
+    },
+    {
+      code: `
+        import Ember from 'ember';
+
+        const {
+          run: foo
+        } = Ember;
+
+        export default Ember.Component({
+          actions: {
+            bar() {
+              foo.next(() => {
+                doSomeWork();
+              });
+            }
+          }
+        });`,
+      parserOptions,
+      errors: [{
+        message: getMessage('foo.next')
+      }]
+    },
+    {
+      code: `
+        import Ember from 'ember';
+
         export default Ember.Component({
           init() {
             Ember.run.debounce(() => {