Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide deprecation notice when subclassing ember bootstrap classes #25

Merged
merged 2 commits into from
Jul 20, 2020

Conversation

basz
Copy link
Contributor

@basz basz commented Jun 25, 2020

@basz
Copy link
Contributor Author

basz commented Jun 25, 2020

travis fails. with 'yarn install --no-lockfile --non-interactive' but runs fine with 'yarn install'.

dunno... seems to come from https://github.com/kaliber5/ember-bootstrap-changeset-validations/blob/master/tests/integration/components/bs-form-element-test.js#L119

@jelhan jelhan changed the title mark class as privileged hide deprecation notice when subclassing ember bootstrap classes Jul 3, 2020
@jelhan
Copy link
Collaborator

jelhan commented Jul 3, 2020

Thanks for working on this one!

should this also be done for https://github.com/kaliber5/ember-bootstrap-changeset-validations/blob/master/addon/components/bs-form/element.js

Yes.

travis fails. with 'yarn install --no-lockfile --non-interactive' but runs fine with 'yarn install'.

Do you see the same for current master or only for this feature branch? If the issue is also on current master it seems to be caused by a new version of some dependency. We would need to track it down to a specific dependency.

@basz
Copy link
Contributor Author

basz commented Jul 7, 2020

On holidays atm... feel free to ping me in ~1.5 weeks

@jelhan
Copy link
Collaborator

jelhan commented Jul 19, 2020

travis fails. with 'yarn install --no-lockfile --non-interactive' but runs fine with 'yarn install'.

See #26. Should be fixed by #27.

@basz
Copy link
Contributor Author

basz commented Jul 20, 2020

ok element class also done

@jelhan
Copy link
Collaborator

jelhan commented Jul 20, 2020

Thanks for the great work! Merged as the failing tests are not related.

@jelhan jelhan merged commit ef98dbc into ember-bootstrap:master Jul 20, 2020
@jelhan jelhan added the bug label Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation notice in ember-bootstrap 4
2 participants