Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation issues for v2.0.x #46

Open
amauryt opened this issue Sep 30, 2020 · 1 comment
Open

Documentation issues for v2.0.x #46

amauryt opened this issue Sep 30, 2020 · 1 comment

Comments

@amauryt
Copy link

amauryt commented Sep 30, 2020

Thank you for the update to this add-on and for ember-bootstrap in general. However, while updating my app I noticed two small issues with the documentation:

  1. The example on the README seems to be for ember-bootstrap-changeset-validations as it uses the changeset helper.
  2. Version 1.x had a nice feature that in certain cases when the cp-validation included presence: true, then it would mark the form element as required (see this line). Given that this seem to not be the case anymore, I think it should have been documented as a breaking change; albeit it would be nice to have this feature back.
@jelhan
Copy link
Collaborator

jelhan commented Oct 26, 2020

The example on the README seems to be for ember-bootstrap-changeset-validations as it uses the changeset helper.

Also noticed that one and opened #62.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants