Merge pull request #1720 from kaliber5/loose-open-modal-arg

Accept loosely typed values for modal `@open`
ember-bootstrap · Jan 8, 2022 · f4de798 · f4de798
2 parents b7eb9c7 + 13fa68d
commit f4de798
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/addon/components/bs-modal.js b/addon/components/bs-modal.js
@@ -639,7 +639,7 @@ export default class Modal extends Component {
 
   @action
   handleVisibilityChanges() {
-    if (this.args.open !== false) {
+    if (this.open) {
       this.show();
     } else {
       this.hide();

diff --git a/tests/integration/components/bs-modal-simple-test.js b/tests/integration/components/bs-modal-simple-test.js
@@ -105,6 +105,26 @@ module('Integration | Component | bs-modal-simple', function (hooks) {
     assert.dom('.modal').doesNotExist('Modal is hidden');
   });
 
+  // https://github.com/kaliber5/ember-bootstrap/issues/1612
+  test('open property accepts loosely types values', async function (assert) {
+    this.set('open', null);
+    await render(
+      hbs`<BsModalSimple @title="Simple Dialog" @fade={{false}} @open={{this.open}}>Hello world!</BsModalSimple>`
+    );
+
+    assert.dom('.modal').doesNotExist('Modal is hidden');
+
+    this.set('open', '');
+    await settled();
+    assert.dom('.modal').doesNotExist('Modal is hidden');
+
+    this.set('open', {});
+    await settled();
+
+    assert.dom('.modal').hasClass(visibilityClass(), 'Modal is visible');
+    assert.dom('.modal').isVisible();
+  });
+
   testRequiringTransitions('open property shows modal [fade]', async function (assert) {
     this.set('open', false);
     await render(hbs`<BsModalSimple @title="Simple Dialog" @open={{this.open}}>Hello world!</BsModalSimple>`);