New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AccordionItem: click on title link does not work #311
Labels
Comments
Ah, yes sure.. I'll do that. |
I think this might be related; accordions seem to be broken on iOS 10 (tried both Safari and Chrome) - could be something to do with the missing preventDefault() in the handler and click propagation. |
Oh and by broken I mean the accordions appear fine, but clicking on them doesn't open the accordion item. Clicking on the title link follows the href, however |
dajk
added a commit
to dajk/ember-bootstrap
that referenced
this issue
Apr 28, 2017
simonihmig
pushed a commit
that referenced
this issue
Apr 28, 2017
simonihmig
pushed a commit
that referenced
this issue
May 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Clicking on the
<a>
does not expand the item, but follows thehref
. See http://www.ember-bootstrap.com/#/components/accordion.Probably introduced with #307. An
e.preventDefault()
in theclick
handler should do the trick. Should be covered by a test.@dajk wanna have a look?
The text was updated successfully, but these errors were encountered: