Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AccordionItem: click on title link does not work #311

Closed
simonihmig opened this issue Apr 27, 2017 · 3 comments · Fixed by #313
Closed

AccordionItem: click on title link does not work #311

simonihmig opened this issue Apr 27, 2017 · 3 comments · Fixed by #313
Assignees
Labels

Comments

@simonihmig
Copy link
Contributor

Clicking on the <a> does not expand the item, but follows the href. See http://www.ember-bootstrap.com/#/components/accordion.

Probably introduced with #307. An e.preventDefault() in the click handler should do the trick. Should be covered by a test.

@dajk wanna have a look?

@dajk
Copy link
Contributor

dajk commented Apr 27, 2017

Ah, yes sure.. I'll do that.

@Techn1x
Copy link
Contributor

Techn1x commented Apr 28, 2017

I think this might be related; accordions seem to be broken on iOS 10 (tried both Safari and Chrome) - could be something to do with the missing preventDefault() in the handler and click propagation.

@Techn1x
Copy link
Contributor

Techn1x commented Apr 28, 2017

Oh and by broken I mean the accordions appear fine, but clicking on them doesn't open the accordion item. Clicking on the title link follows the href, however

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants