Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No transition for bs-collapse #629

Closed
drakej opened this issue Jul 16, 2018 · 3 comments
Closed

No transition for bs-collapse #629

drakej opened this issue Jul 16, 2018 · 3 comments
Labels

Comments

@drakej
Copy link

drakej commented Jul 16, 2018

Output from ember bootstrap:info (available since 1.0.0-alpha.9):

Npm packages:
ember-bootstrap: ^1.2.0 -> 1.2.0
ember-cli: ~2.14.2 -> 2.14.2
bootstrap: ^4.0.0 -> 4.0.0
bootstrap-sass: n/a
ember-cli-sass: ^6.2.0 -> 6.2.0
ember-cli-less: n/a
Bower packages:
bootstrap: n/a
bootstrap-sass: n/a
ember-bootstrap configuration:
bootstrapVersion: 4
importBootstrapFont: false
importBootstrapCSS: false

https://www.ember-bootstrap.com/#/components/collapse

^ On this demo if you "Hide" the collapsed content it has no transition of 350 ms. It just abruptly closes.

Contrast that with Bootstrap 4's demo:

https://getbootstrap.com/docs/4.1/components/collapse/#example

Also I don't understand why there's a configurable called transitionDuration when that doesn't exist in bootstrap itself. It seems like the entire solution is a rewrite in terms of the javascript behavior and the only bootstrap aspect is the CSS itself.

@simonihmig
Copy link
Contributor

^ On this demo if you "Hide" the collapsed content it has no transition of 350 ms. It just abruptly closes.

I cannot reproduce this, works for me. 🤔
Which browser are you using?
Does it happen always, or is it somewhat timing related?

@scottharris86
Copy link

Hi I'd like to maybe help reproduce this issue. I have the same issue after updating from 1.0 to 2.5.
in 1.0 and on bootstrap website using the link provided above. theres a nice smooth transition where the collapse transitions down to open state. in 2.5 on your demo site and in my app. there is not a transition. it just abruptly opens.. theres no animation anymore. maybe thats the word were looking for? animation? also for full disclosure im using an accordian but the behavior should be the same for both. let me know what i can do to help. Thank you

@simonihmig
Copy link
Contributor

Hm, this is weird. At the time I was trying to reproduce this, it was definitely working right, at least what I was seeing in my browser. But now indeed there is no transition. This might be caused or exacerbate by some recent changes!?

Will investigate...

simonihmig added a commit that referenced this issue Feb 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants