Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Un-deprecate BsButton's buttonType argument #1110

Merged
merged 1 commit into from Jun 15, 2020
Merged

Un-deprecate BsButton's buttonType argument #1110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion addon/components/base/bs-button.js
View file
Open in desktop
Expand Up @@ -476,7 +476,6 @@ export default class Button extends Component {
// deprecate arguments used for attribute bindings only
runInDebug(() => {
[
['buttonType:type', 'submit'],
['disabled', true],
['title', 'foo'],
].forEach(([mapping, value]) => {
Expand Down
1 change: 0 additions & 1 deletion tests/integration/components/bs-button-test.js
View file
Open in desktop
Expand Up @@ -77,7 +77,6 @@ module('Integration | Component | bs-button', function(hooks) {
await render(hbs`{{bs-button buttonType="submit"}}`);

assert.dom('button').hasAttribute('type', 'submit');
assert.deprecationsInclude('Argument buttonType of <BsButton> component is deprecated.');
});

test('button with icon property shows icon', async function(assert) {
Expand Down