-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace ember-ref-modifier to ember-ref-bucket #1182
Replace ember-ref-modifier to ember-ref-bucket #1182
Conversation
@lifeart thanks for working on this! I haven't looked deeply into Shouldn't both addons be able to co-exist? This would mean to rename the |
I whould like to have only one
|
|
|
Cool! Nice work! |
May I kindly ping for a release? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! 👍
Looks good, just two little things to fix...
c4017ab
to
7338d32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Since ember-ref-modifier has list of downsides (runloop scheduling), api design, I will suggest to replace it to new implementation.
https://github.com/lifeart/ember-ref-bucket
refs:
lifeart/ember-ref-modifier#345
lifeart/ember-ref-modifier#203
lifeart/ember-ref-modifier#232