Remove useDefaultValueIfUndefined optional feature, make it default behavior #1283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Only failing for Canary, which should be fixed by #1284 |
…ehavior As discussed in #1282 (comment), we remove the optional feature introduced in #1248 again, and make its behavior the default one.
simonihmig
force-pushed
the
undefined-fallback
branch
from
6d3bf8b
to
33d4456
Compare
jelhan
approved these changes
Oct 12, 2020
|
I think this should be mentioned in the changelog. Not that sure about the title so. Technically it's about removing the optional feature. But from a consumer point of view it's about supporting passing arguments through without needing to worry about default values. I guess for better changelog the title should focus on that one. |
simonihmig
changed the title
|
Changed the title. Feel free to change again if you have something better, at least until it's release time again! 😉 |
simonihmig
changed the title
|
Just reverted that, and added the title and label to your PR, so you are correctly credited for that change! 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1282 (comment), we remove the optional feature introduced in #1248 again, and make its behavior the default one.