Drop IE11 support #1596
Merged
Drop IE11 support #1596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelhan
reviewed
Aug 10, 2021
There was a problem hiding this comment.
@jelhan I think we can also basically revert the changes of #775 here, or is there still any value in keeping the this fallback behavior?
I think we can revert. If I recall correctly only IE11 throws if using unsupported type.
Comment on lines
-5
to
-10
| const isCI = Boolean(process.env.CI); | ||
| const isProduction = process.env.EMBER_ENV === 'production'; | ||
|
|
||
| if (isCI || isProduction) { | ||
| browsers.push('ie 11'); | ||
| } |
There was a problem hiding this comment.
Should we also remove IE11 from build targets for documentation app? https://github.com/kaliber5/ember-bootstrap/blob/master/docs/config/targets.js
jelhan
approved these changes
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Ember 4.0 will also drop it, there is no point in keeping support.
@jelhan I think we can also basically revert the changes of #775 here, or is there still any value in keeping the this fallback behavior?