Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing tests for assertion of href attribute for BsNavbar #1787

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions tests/acceptance/bs-nav-link-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,11 @@ module('Acceptance | bs-nav-link', function (hooks) {
assert.dom(this.element.querySelectorAll('.nav li')[1]).hasClass('active');
assert.dom(this.element.querySelectorAll('.nav li')[2]).hasClass('active');
});

test('href exists in anchor inside nav item', async function (assert) {
await visit('/acceptance/link/1');
assert.dom(this.element.querySelectorAll('.nav li a')[0]).hasAttribute('href', '/acceptance/link/1');
assert.dom(this.element.querySelectorAll('.nav li a')[1]).hasAttribute('href', '/acceptance/link/2');
assert.dom(this.element.querySelectorAll('.nav li a')[2]).hasAttribute('href', '/acceptance/link/1');
});
});
15 changes: 15 additions & 0 deletions tests/integration/components/bs-navbar/nav-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -55,4 +55,19 @@ module('Integration | Component | bs-navbar/nav', function (hooks) {
`);
assert.dom('a').hasClass('nav-link');
});

test('link has href attribute', async function (assert) {
this.owner.setupRouter();

await render(hbs`
<BsNavbar as |navbar|>
<navbar.nav as |nav|>
<nav.item>
<nav.link-to @route="acceptance.modal">Link</nav.link-to>
</nav.item>
</navbar.nav>
</BsNavbar>
`);
assert.dom('a').hasAttribute('href', '/acceptance/modal');
});
});