New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Create bootstrap 3, ember 4 compatible fork #1837
base: master
Are you sure you want to change the base?
Conversation
@Gaurav0 What is the status of this? I'm open to release a v4.10.0, which adds support for Ember v4 to Ember Bootstrap's v4.x. Let me know if you want to push the PR to that state. |
I had a quick look at the changes. It seems that it includes some breaking changes. At least dropping support for node 10. Download counts for 4.9.0 on npmjs.com are also relatively low. Actually 3.1.4 has more downloads in last 7 days. To summarize: Releasing doesn't seem to be straightforward. And it seems to have relatively low value. But let's keep this MR open for now to ease discovering it for teams in a similar situation as you. |
Yes, I mentioned this in the description above. Supporting node 10/12 or IE 11 was not a priority for my team since Ember 4 doesn't support either. If only there were a number between 4 and 5 :) |
V4 -- DO NOT MERGE TO MASTER
ember-bootstrap 4.9.0 is compatible with bootstrap 3.x but not ember 4.x
ember-bootstrap 5.0+ is compatible with ember 4.x but not bootstrap 3.x
This PR starts at tag v4.9.0 and cherry picks commits on the 5.x branch to get ember 4.x working
Opening this PR here for visibility, so that if anyone else in this situation where they are stuck on Bootstrap 3 but need to get to Ember 4, they can.
Feel free to merge to a separate branch, but obviously not master. Feel free to publish as v4.10, if you want, although it isn't strictly semver as it doesn't work with IE11 or node 10/12.