Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial typescript configuration to addon project #2092

Merged
merged 2 commits into from Feb 10, 2024
Merged

Conversation

SanderKnauff
Copy link
Contributor

This adds Typescript support to the addon project.
At this moment, it does not touch the test-app and docs projects yet.

Copy link
Contributor

@simonihmig simonihmig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Any reason to have this tagged as WIP actually?

We don't expose the types in the published package yet, that stuff is still missing. But I assume this was intentional, to only expose the types when we are ready to?

@SanderKnauff
Copy link
Contributor Author

LGTM! Any reason to have this tagged as WIP actually?

We don't expose the types in the published package yet, that stuff is still missing. But I assume this was intentional, to only expose the types when we are ready to?

I put it as WIP because I wasn't yet sure if I had missed anything, such as the typesVersions object that I actually did miss. 😅

Shall I add it in? I'm not sure if it would be a big issue if we ship partial types until we're completely done.

@simonihmig
Copy link
Contributor

I'm not sure if it would be a big issue if we ship partial types until we're completely done.

Yeah, probably it doesn't hurt really. So we can add that I guess!

@SanderKnauff SanderKnauff changed the title [WIP] Add initial typescript configuration to addon project Add initial typescript configuration to addon project Feb 10, 2024
@simonihmig
Copy link
Contributor

I think we will need some more tweaking of the config. But this is better done when we actually have some TS code to play with. I am currently working on some initial TS conversion, so will probably bring up some tweaks with the next PR!

So let's get this merged first! Thanks @SanderKnauff!

@simonihmig simonihmig merged commit ce7e5a7 into master Feb 10, 2024
22 checks passed
@simonihmig simonihmig deleted the typescript branch February 10, 2024 20:33
@simonihmig
Copy link
Contributor

so will probably bring up some tweaks with the next PR

See e641f84

@jelhan jelhan mentioned this pull request Feb 14, 2024
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants