Fix alignment of dropdown menus when using Bootstrap 5 #2120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bootstrap 5 uses start/end instead of left/right. The menu was still using the value from the align argument. In addition to this, the styles used in Bootstrap 5 check for the existence of the [data-bs-popper] attribute. This has been added to the menu as well
jelhan
requested changes
Apr 10, 2024
|
|
||
| switch (this.align) { | ||
| case 'left': | ||
| return 'dropdown-menu-start'; |
There was a problem hiding this comment.
I double checked in Bootstrap docs for v5. If I get it right, .dropdown-menu-start is not needed as that's the default: https://getbootstrap.com/docs/5.3/components/dropdowns/#menu-alignment
There was a problem hiding this comment.
Ah, I had not noticed that. I will remove the left/start
| ); | ||
| assert | ||
| .dom('.dropdown-menu') | ||
| .hasClass(alignmentClass, `menu has ${alignmentClass} class`); |
There was a problem hiding this comment.
I think we do t expect it to have a class in BS4 and 5.
- https://getbootstrap.com/docs/5.3/components/dropdowns/#menu-alignment
- https://getbootstrap.com/docs/4.6/components/dropdowns/#menu-alignment
I think we should assert that it does not have any class except .dropdown-menu. Not sure how well that's supported by qunit-dom.
There was a problem hiding this comment.
QUnit DOM may not, but I'll do the assertions on the classlist.
jelhan
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bootstrap 5 uses start/end instead of left/right. The menu was still using the value from the align argument. In addition to this, the styles used in Bootstrap 5 check for the existence of the [data-bs-popper] attribute. This has been added to the menu as well.
I noticed this issue while converting the app at work from BS4 to BS5.
Before fix:
After fix:
