Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modernize hbs import in tests #2122

Merged
merged 1 commit into from
Apr 10, 2024
Merged

modernize hbs import in tests #2122

merged 1 commit into from
Apr 10, 2024

Conversation

jelhan
Copy link
Contributor

@jelhan jelhan commented Apr 10, 2024

Importing hbs from htmlbars-inline-precompile-template is an outdated pattern. And it does not support TypeScript. This PR modernizes all imports at once to TypeScript conversion and lower the barrier of entrance.

Copy link
Contributor

@SanderKnauff SanderKnauff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This will certainly help with Typescript/Glint conversion!

@jelhan jelhan merged commit 5dad0c8 into master Apr 10, 2024
22 checks passed
@jelhan jelhan deleted the modernize-hbs-import-in-tests branch April 10, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants