Provide required & disabled functionality #71
Conversation
|
Did the same yesterday already, but did not push yet... :( Does this include all of #67? So those PRs are mutually exclusive? Did not have time to check in detail... |
|
It doesnt but I can add it super quick |
All credit goes to @ oswaldoacauan
|
@simonihmig added disabled functionality. Please give credit to @oswaldoacauan for that. |
|
I will close my PR. Good work @offirgolan 馃憦 |
offirgolan
changed the title
|
@offirgolan regarding my last question: just had a quick glance at it and did not realize the 2 PRs were about two different things (disabled & required), sorry about the confusion! Great that you could merge both into one nevertheless, would have caused merge conflicts everywhere otherwise... @offirgolan & @oswaldoacauan: thanks for your combined effort, credits will go to both of you of course! :) |
feat(FormElement): Provide required & disabled functionality. Thanks to @offirgolan and @oswaldoacauan Closes #66
|
No worries at all! It was probably faster doing them both together than spending the time to merge 15 files 馃樃 |
I also updated the dev dependencies since tests werent running on my local machine. 馃槃