Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(BsForm): adds failing test for pull request #766 #768

Merged
merged 1 commit into from Mar 5, 2019

Conversation

jelhan
Copy link
Contributor

@jelhan jelhan commented Mar 5, 2019

A test for BS4 is not needed cause inline=true only affects rendering an additional class for that one.

A test for BS4 is not needed cause `inline=true` only affects rendering
an additional class for that one.
@simonihmig
Copy link
Contributor

Thank you!

Btw, please don't use this conventional changelog style of PR titles (test(x): foo, feat(x): bar), but just plain human readable descriptions of the changes. The PR titles are used for automatic changelog generation (via lerna-changelog), when one of the supported labels has been applied (see https://github.com/kaliber5/ember-bootstrap/blob/master/package.json#L129-L133). Should probably add this to the Contributing.md! Fyi ;)

@simonihmig simonihmig merged commit b7303a0 into ember-bootstrap:master Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants