Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Credentials should not be required #32

Closed
quiddle opened this issue Dec 17, 2015 · 2 comments
Closed

AWS Credentials should not be required #32

quiddle opened this issue Dec 17, 2015 · 2 comments

Comments

@quiddle
Copy link
Contributor

quiddle commented Dec 17, 2015

Hard-coding AWS credentials is the least recommended option:

  1. Loaded from IAM roles for Amazon EC2 (if running on EC2),
  2. Loaded from the shared credentials file (~/.aws/credentials),
  3. Loaded from environment variables,
  4. Loaded from a JSON file on disk,
  5. Hardcoded in your application

By requiring the AWS Credentials, it prevents using these other methods.

The ember-cli-deploy-s3 plugin recently fixed this with pull request 39.

~~I'm also fairly certain that if region is specified in a ~/.aws/config file, it will get picked up by the AWS SDK as well. Looking into that for sure.~~

@LevelbossMike
Copy link
Member

Thx for this issue! This sounds like a useful change. Do you want to submit a PR for this?

@LevelbossMike
Copy link
Member

Fixed via #33 Thx again @quiddle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants