Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Incorrect #518

Open
beanshearer opened this issue Jun 10, 2020 · 1 comment
Open

Documentation Incorrect #518

beanshearer opened this issue Jun 10, 2020 · 1 comment

Comments

@beanshearer
Copy link

beanshearer commented Jun 10, 2020

http://ember-cli-deploy.com/docs/v0.6.x/fingerprinting/

This includes this line:

var env = EmberApp.env();
var isProductionLikeBuild = ['production', 'staging'].indexOf(env) > -1;

But as far as I am aware, there is no 'staging' environment, so when you set the deploy target to 'staging' or try and set the environment to ''staging', it actually just defaults to development in the config/environment. This bit of misleading documentation has caused us a lot of confusion so please could this be updated/clarified?

@ghedamat
Copy link
Collaborator

sorry for the long delay @beanshearer , wanna open a PR to clarify? I think you're correct indeed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants