Add a mode that converts to @embroider/macros #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is intended as a compatibility path for packages (like ember-source) that make heavy use of babel-plugin-debug-macros and want to become valid V2 addons. A v2 addon can't bring its own custom build pipeline along into apps. If they want to make compile-time decisions, they need to do it through the standardized `@embroider/macros`. This implementation does the smallest, simplest thing, which is replacing the hard-coded boolean we used to emit with a call to `isDevelopingApp()` from '@embroider/macros`. It relies on the same kind of dead-code elimination that this babel plugin has always relied on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended as a compatibility path for packages (like ember-source) that make heavy use of babel-plugin-debug-macros and want to become valid V2 addons.
A v2 addon can't bring its own custom build pipeline along into apps. If they want to make compile-time decisions, they need to do it through the standardized
@embroider/macros.This implementation does the smallest, simplest thing, which is replacing the hard-coded boolean we used to emit with a call to
isDevelopingApp()from '@embroider/macros`. It relies on the same kind of dead-code elimination that this babel plugin has always relied on.