Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

needs to support caching #17

Closed
stefanpenner opened this issue Aug 19, 2016 · 9 comments
Closed

needs to support caching #17

stefanpenner opened this issue Aug 19, 2016 · 9 comments

Comments

@stefanpenner
Copy link
Contributor

https://github.com/babel/broccoli-babel-transpiler#caching

cc @rwjblue

@rwjblue
Copy link
Member

rwjblue commented Aug 19, 2016

Wat?

@rwjblue
Copy link
Member

rwjblue commented Aug 19, 2016

That was what #15 was for

@stefanpenner
Copy link
Contributor Author

interesting, master does not appear to have this https://github.com/ember-cli/babel-plugin-htmlbars-inline-precompile/blob/master/index.js Is it intended only for the 1.x stable?

@rwjblue
Copy link
Member

rwjblue commented Aug 19, 2016

Unsure. I didn't focus on Babel 6 support at all.

@stefanpenner
Copy link
Contributor Author

Ok, my use-case is actually the 1.x branch. I mis-understood the issue and just noticed my dep was stale.... Overzealous lock file.

Lets leave this open for the future, so we eventually address master.

@Turbo87
Copy link
Member

Turbo87 commented Aug 19, 2016

Didn't you say that this wasn't necessary for Babel 6 since the options are used as a cache key there?

@rwjblue
Copy link
Member

rwjblue commented Aug 19, 2016

I do recall the convo, but this one is weird since Babel 6 doesn't really support this kind of require in the rc file (AFAIK). We will basically need to make it use npm based ember I think, and just resolve the module or something.

@stefanpenner
Copy link
Contributor Author

stefanpenner commented Aug 19, 2016

ah, so this may be invalid in babel 6?

@rwjblue
Copy link
Member

rwjblue commented Aug 19, 2016

@stefanpenner - ya, but still a bit TBD. This issue is fine generally speaking, we will have to deal with it as part of the Babel 6 efforts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants