Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failing tests for fingerprinting srcset #50

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

samdemaeyer
Copy link

Fingerprinting srcset is not working.

Expected:

<img src="https://cloudfront.net/images/my-folder/my-image-fingerprinted.png" srcset="https://cloudfront.net/images/my-folder/my-image-fingerprinted.png 1x, https://cloudfront.net/images/my-folder/my-image-fingerprinted_@2.png 2x" />

Actual:

<img src="https://cloudfront.net/images/my-folder/my-image-fingerprinted.png" srcset="https://cloudfront.net/images/my-folder/my-image-fingerprinted.png 1x, /images/my-folder/my-image_@2x.png 2x" />

screen shot 2017-01-03 at 12 52 59

@samdemaeyer
Copy link
Author

Issue #51

@rickharrison
Copy link
Collaborator

Thanks for the failing test!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants