Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update regex for finding instances of assetPath #64

Merged
merged 3 commits into from Aug 13, 2018

Conversation

gojefferson
Copy link
Contributor

@gojefferson gojefferson commented Dec 10, 2017

This is intended to fix #65

@omairvaiyani
Copy link

Thanks @gojefferson this fixed worked for me.

It was breaking on this exact line when confronted with bootstrap's css map.

Would like this patch merged ideally!

@gojefferson
Copy link
Contributor Author

Thanks @omairvaiyani! Agreed, would be great for it to be merged.

@lennyburdette
Copy link

I also just ran into this today. Would you be able to add a test case? Happy to help!

@gojefferson
Copy link
Contributor Author

@lennyburdette adding a test case would be great. This PR seems like a pretty clear win. Any ideas on what we can do to get it merged?

@lennyburdette
Copy link

@gojefferson once there's a test case for this bug, I think you can 👋 at rwjblue either here or in the Ember community slack to get it merged.

@gojefferson
Copy link
Contributor Author

@lennyburdette I'd love to have your help adding a test case. I'm a bit strapped for time recently, but I could perhaps work on it over the weekend sometime.

@g-cassie
Copy link

This issue came up for us today due to some changes in the webpack library. It looks like others are actively working on this PR in the last few hours - is a new release imminent?

@gojefferson
Copy link
Contributor Author

@g-cassie I don't know. I did ping one of the ember team members in ember-community slack today, so hopefully they'll merge the PR. Seems like a no-brainer to me ¯_(ツ)_/¯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regex for matching assetPath picks up noise in certain cases
6 participants