fix: Fix sourcemap file lookup #313
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| 'use strict'; | ||
|
|
||
| // Forked from https://github.com/lydell/source-map-url/blob/master/source-map-url.js | ||
| // We use a slightly adjusted regex here | ||
| const convertSourceMap = require('convert-source-map'); | ||
|
|
||
| module.exports = { | ||
| regex: convertSourceMap.mapFileCommentRegex, | ||
|
|
||
| reset() { | ||
| this.regex = convertSourceMap.mapFileCommentRegex; | ||
| }, | ||
|
|
||
| getFrom(code) { | ||
| const m = this.regex.exec(code); | ||
| return m ? m[1] || m[2] : null; | ||
| }, | ||
| }; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| function createURL(base64, sourcemapArg, enableUnicodeArg) { | ||
| var sourcemap = sourcemapArg === undefined ? null : sourcemapArg; | ||
| var enableUnicode = enableUnicodeArg === undefined ? false : enableUnicodeArg; | ||
| var source = decodeBase64(base64, enableUnicode); | ||
| var start = source.indexOf('\n', 10) + 1; | ||
| var body = source.substring(start) + (sourcemap ? '\/\/# sourceMappingURL=' + sourcemap : ''); | ||
| var blob = new Blob([body], { type: 'application/javascript' }); | ||
| return URL.createObjectURL(blob); | ||
| } | ||
|
|
||
| function createURL2(base64, sourcemapArg, enableUnicodeArg) { | ||
| var sourcemap = sourcemapArg === undefined ? null : sourcemapArg; | ||
| var enableUnicode = enableUnicodeArg === undefined ? false : enableUnicodeArg; | ||
| var source = decodeBase64(base64, enableUnicode); | ||
| var start = source.indexOf('\n', 10) + 1; | ||
| var body = source.substring(start) + (sourcemap ? '//# sourceMappingURL=' + sourcemap : ''); | ||
| var blob = new Blob([body], { type: 'application/javascript' }); | ||
| return URL.createObjectURL(blob); | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any way we can use convert-source-map directly instead of needing teh lib/source-map-url.js file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to work a bit differently, and I didn't find a good method it exposed (?) to just get all source map URLs in a file - there is a method to just get the last one, and a method to remove all of them in the file, both of which are not suited to what we need here 😓