Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some sort of feedback when --verbose=false #276

Closed
achambers opened this issue Oct 28, 2015 · 9 comments
Closed

Add some sort of feedback when --verbose=false #276

achambers opened this issue Oct 28, 2015 · 9 comments
Labels
Milestone

Comments

@achambers
Copy link
Member

Now that we have turned off the logging unless --verbose is set some people are feeling like they are missing some form of feedback that something is happening.

Might be worth thinking about adding some sort of simple spinner (maybe like ember install uses) when the verbose flag is false.

@ghedamat
Copy link
Collaborator

or maybe just a couple of simple

starting deploy...
deploy done!

messages?

@achambers
Copy link
Member Author

Sure...Anything....It might be nice to use https://www.npmjs.com/package/pleasant-progress like ember-cli does to give a perception of something actively happening.

Dunno...It's just feedback I've been given based on the new "no output by default". While the general inspiration is "if there is no output then everything is good" maybe something small like this might be helpful.

@ghedamat
Copy link
Collaborator

understood

will see if I can do something on plane :D

@jrowlingson
Copy link
Contributor

+1 - I spent more time than I should have last night trying to figure out why my plugin was not logging anything.

@ghedamat
Copy link
Collaborator

@jrowlingson you're talking about a plugin you're writing right?

for that we definitely need to add mention of the new verbose option
on the docs

http://ember-cli.github.io/ember-cli-deploy/docs/v0.5.x/writing-a-plugin/

I'll see if I can get to that as well while I fly to embercamp

@achambers
Copy link
Member Author

Thanks @ghedamat.

@jrowlingson
Copy link
Contributor

@ghedamat Yes, I have started working on the github plugin.

@ghedamat
Copy link
Collaborator

@jrowlingson glad to hear!

you probably figured it out already but you can do this
https://github.com/ember-cli-deploy/ember-cli-deploy-redis/blob/master/index.js#L69
to make the log always show

otherwise pass the --verbose option.

feel free to reach out on #ember-cli-deploy on the ember slack if you need help!

@lukemelia lukemelia added the 0.6.x label Jan 7, 2016
@lukemelia lukemelia added this to the 0.6.x milestone Jan 7, 2016
@lukemelia
Copy link
Contributor

Closed by #280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants