Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addons are eslinted when imported #14

Closed
ezpuzz opened this issue May 18, 2015 · 9 comments
Closed

addons are eslinted when imported #14

ezpuzz opened this issue May 18, 2015 · 9 comments
Labels

Comments

@ezpuzz
Copy link

ezpuzz commented May 18, 2015

in my case we are extending the ember-rapid-forms components to be compatible with foundation.
when running ember serve initially or ember test with the generator in the readme.

I've tried using // eslint-disable-line at the end of the import lines, but the imported modules are still linted (and the imports of those modules).

Is there a workaround to disable linting of certain imports?

Is there a way you could not lint files that were part of an addon?

@jonathanKingston
Copy link
Member

Are the addon files within vendor, node_modules or bower?

@ezpuzz
Copy link
Author

ezpuzz commented May 19, 2015

node_modules, installed with npm

@jonathanKingston
Copy link
Member

I'll look at it tomorrow, those files were out of scope before. Thanks for reporting.

@ezpuzz
Copy link
Author

ezpuzz commented May 19, 2015

with the latest beta i can use **/modules/** in the .eslintignore and that gets rid of errors on the addons.
there is probably a better way though.
also even though no errors are displayed I do get a bunch of newlines being printed during the Building... step only when ember-cli-eslint is run.

@ezpuzz
Copy link
Author

ezpuzz commented Jun 1, 2015

the newlines are really making my CI logs look nasty, any way you could figure out what is causing a bunch of newlines to spit out?

@jonathanKingston
Copy link
Member

Should be fixed in the latest beta, kick the module and reinstall.
I'll release another version tonight which shouldn't require the aggressive
delete and reinstall.

On Mon, Jun 1, 2015 at 8:21 AM Emory Petermann notifications@github.com
wrote:

the newlines are really making my CI logs look nasty, any way you could
figure out what is causing a bunch of newlines to spit out?


Reply to this email directly or view it on GitHub
#14 (comment)
.

@ezpuzz
Copy link
Author

ezpuzz commented Jun 2, 2015

👍 beta.13 seems to be working nicely

@bttf
Copy link

bttf commented Oct 29, 2015

I experienced the same issue today after installing the ember liquid-fire add-on. It was only linting the liquid-fire add-on out of my other add-ons. The add-on was installed via ember install liquid-fire and was located inside node_modules

Adding **/modules/** to .eslintignore did fix it; I was also able to reproduce the issue by just creating a new ember project, installing ember-cli-eslint, then liquid-fire and then running ember build

@ezpuzz
Copy link
Author

ezpuzz commented Oct 29, 2015

also I think if addon.isDevelopingAddon is set improperly inside the addon it can trigger your parent project to lint the addon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants