This repository has been archived by the owner on Nov 25, 2018. It is now read-only.
Upgrades to the latest Ember CLI #79
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
reviewed
Jan 11, 2017
| @@ -1,6 +1,6 @@ | |||
| The MIT License (MIT) | |||
|
|
|||
| Copyright (c) 2015-2016 | |||
| Copyright (c) 2017 | |||
There was a problem hiding this comment.
this should likely be fixed in the default blueprint?
There was a problem hiding this comment.
how would you fix that? it depends on the project that you're using ember init on.
| - "4" | ||
| - "0.12" | ||
| - "5" |
There was a problem hiding this comment.
we should probably test against 4, 6, stable at this point
Turbo87
approved these changes
Jan 11, 2017
nathanhammond
suggested changes
Jan 11, 2017
| - "4" | ||
| - "0.12" | ||
| - "6" | ||
| - "stable" |
There was a problem hiding this comment.
Mild preference for calling this 7 since https://github.com/creationix/nvm/blob/f1a5f2a15fd2867a4a5762b80cae028d324ee6a1/README.markdown#L182
| }, | ||
| "repository": "https://github.com/ember-cli/ember-cli-legacy-blueprints", | ||
| "engines": { | ||
| "node": ">= 0.12" | ||
| "node": ">= 4" |
There was a problem hiding this comment.
4 || 6 || 7 ... 5 isn't supported.
|
closing due to inactivity and open merge conflicts. I guess we should probably archive this whole project as it's no longer needed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.