Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve addon support #23

Open
1 of 3 tasks
trentmwillis opened this issue Mar 27, 2016 · 2 comments
Open
1 of 3 tasks

Improve addon support #23

trentmwillis opened this issue Mar 27, 2016 · 2 comments

Comments

@trentmwillis
Copy link
Member

trentmwillis commented Mar 27, 2016 •
edited by Turbo87
Loading

Since a lot of the Ember testing ecosystem relies on this addon, seems like there could be a bit better support behind it. In particular I feel like the following could be beneficial:

  • Document public/private APIs (everything appears public currently)
  • Add tests
  • ES6ify the code (it is using ES6 modules but everything else is ES3 or so)

If these seem desirable I can work on implementing them. Though I'd need a bit of guidance on the documentation front.
@rwjblue
Copy link
Member

rwjblue commented Apr 6, 2017

Totally agreed with all points!!!

@rwjblue
Copy link
Member

rwjblue commented Apr 6, 2017

(Optional) ES6ify the code (it is using ES6 modules but everything else is ES3 or so)

Done in #34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rwjblue @trentmwillis