Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What should happen when failure to load a module? #39

Open
step2yeung opened this issue Dec 6, 2018 · 0 comments
Open

What should happen when failure to load a module? #39

step2yeung opened this issue Dec 6, 2018 · 0 comments

Comments

@step2yeung
Copy link

step2yeung commented Dec 6, 2018 •
edited
Loading

Currently, when requiring a test file, if an error gets throw, the error is logged by console.error() and the test-loader will continue to require the next test file.
See https://github.com/ember-cli/ember-cli-test-loader/blob/master/addon-test-support/index.js#L71

This effectively ignores all the tests that are part of the test file that did not get required, which would cause unexpected missing test coverage.

Was interested in knowing what is the rational in the choice of the current implementation.
@rwjblue would you have some context on this?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@step2yeung