Skip to content

Commit

Permalink
Merge pull request #3891 from marcioj/issue-3886
Browse files Browse the repository at this point in the history
Fixes problem in initializer tests generated in addons
  • Loading branch information
stefanpenner committed Apr 16, 2015
2 parents 9363be9 + bb2ba2f commit 792075d
Show file tree
Hide file tree
Showing 13 changed files with 56 additions and 19 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export { default, <%= camelizedModuleName %> } from '<%= modulePath %>';
3 changes: 3 additions & 0 deletions blueprints/helper-addon/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
/*jshint node:true*/

module.exports = require('../addon-import');
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import {
<%= camelizedModuleName %>
} from '../../../helpers/<%= dasherizedModuleName %>';
} from '<%= dependencyDepth %>/helpers/<%= dasherizedModuleName %>';
import { module, test } from 'qunit';

module('<%= classifiedModuleName %>Helper');
Expand Down
9 changes: 8 additions & 1 deletion blueprints/helper-test/index.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
/*jshint node:true*/

var getDependencyDepth = require('../../lib/utilities/get-dependency-depth');

module.exports = {
description: 'Generates a helper unit test.'
description: 'Generates a helper unit test.',
locals: function(options) {
return {
dependencyDepth: getDependencyDepth(options)
}
}
};
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export { default, initialize } from '<%= modulePath %>';
3 changes: 3 additions & 0 deletions blueprints/initializer-addon/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
/*jshint node:true*/

module.exports = require('../addon-import');
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import Ember from 'ember';
import { initialize } from '../../../initializers/<%= dasherizedModuleName %>';
import { initialize } from '<%= dependencyDepth %>/initializers/<%= dasherizedModuleName %>';
import { module, test } from 'qunit';

var container, application;
Expand Down
9 changes: 8 additions & 1 deletion blueprints/initializer-test/index.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
/*jshint node:true*/

var getDependencyDepth = require('../../lib/utilities/get-dependency-depth');

module.exports = {
description: 'Generates an initializer unit test.'
description: 'Generates an initializer unit test.',
locals: function(options) {
return {
dependencyDepth: getDependencyDepth(options)
}
}
};
11 changes: 11 additions & 0 deletions lib/utilities/get-dependency-depth.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
'use strict';

module.exports = function getDependencyDepth(options) {
var name = options.entity.name;
var nameParts = name.split('/');
var depth = '../..';

return nameParts.reduce(function(prev) {
return prev + '/..';
}, depth);
};
10 changes: 5 additions & 5 deletions tests/acceptance/addon-generate-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ describe('Acceptance: ember generate in-addon', function() {
});
assertFile('app/helpers/foo-bar.js', {
contains: [
"export { default } from 'my-addon/helpers/foo-bar';"
"export { default, fooBar } from 'my-addon/helpers/foo-bar';"
]
});
assertFile('tests/unit/helpers/foo-bar-test.js', {
Expand All @@ -202,13 +202,13 @@ describe('Acceptance: ember generate in-addon', function() {
});
assertFile('app/helpers/foo/bar-baz.js', {
contains: [
"export { default } from 'my-addon/helpers/foo/bar-baz';"
"export { default, fooBarBaz } from 'my-addon/helpers/foo/bar-baz';"
]
});
assertFile('tests/unit/helpers/foo/bar-baz-test.js', {
contains: "import {" + EOL +
" fooBarBaz" + EOL +
"} from '../../../helpers/foo/bar-baz';"
"} from '../../../../helpers/foo/bar-baz';"
});
});
});
Expand Down Expand Up @@ -416,7 +416,7 @@ describe('Acceptance: ember generate in-addon', function() {
});
assertFile('app/initializers/foo.js', {
contains: [
"export { default } from 'my-addon/initializers/foo';"
"export { default, initialize } from 'my-addon/initializers/foo';"
]
});
assertFile('tests/unit/initializers/foo-test.js');
Expand All @@ -437,7 +437,7 @@ describe('Acceptance: ember generate in-addon', function() {
});
assertFile('app/initializers/foo/bar.js', {
contains: [
"export { default } from 'my-addon/initializers/foo/bar';"
"export { default, initialize } from 'my-addon/initializers/foo/bar';"
]
});
assertFile('tests/unit/initializers/foo/bar-test.js');
Expand Down
10 changes: 7 additions & 3 deletions tests/acceptance/generate-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ describe('Acceptance: ember generate', function() {
assertFile('tests/unit/helpers/foo/bar-baz-test.js', {
contains: "import {" + EOL +
" fooBarBaz" + EOL +
"} from '../../../helpers/foo/bar-baz';"
"} from '../../../../helpers/foo/bar-baz';"
});
});
});
Expand Down Expand Up @@ -451,7 +451,9 @@ describe('Acceptance: ember generate', function() {
"};"
});

assertFile('tests/unit/initializers/foo-test.js');
assertFile('tests/unit/initializers/foo-test.js', {
contains: "import { initialize } from '../../../initializers/foo';"
});
});
});

Expand All @@ -468,7 +470,9 @@ describe('Acceptance: ember generate', function() {
"};"
});

assertFile('tests/unit/initializers/foo/bar-test.js');
assertFile('tests/unit/initializers/foo/bar-test.js', {
contains: "import { initialize } from '../../../../initializers/foo/bar';"
});
});
});

Expand Down
10 changes: 5 additions & 5 deletions tests/acceptance/in-repo-addon-generate-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ describe('Acceptance: ember generate in-repo-addon', function() {
});
assertFile('lib/my-addon/app/helpers/foo-bar.js', {
contains: [
"export { default } from 'my-addon/helpers/foo-bar';"
"export { default, fooBar } from 'my-addon/helpers/foo-bar';"
]
});
assertFile('tests/unit/helpers/foo-bar-test.js', {
Expand All @@ -212,13 +212,13 @@ describe('Acceptance: ember generate in-repo-addon', function() {
});
assertFile('lib/my-addon/app/helpers/foo/bar-baz.js', {
contains: [
"export { default } from 'my-addon/helpers/foo/bar-baz';"
"export { default, fooBarBaz } from 'my-addon/helpers/foo/bar-baz';"
]
});
assertFile('tests/unit/helpers/foo/bar-baz-test.js', {
contains: "import {" + EOL +
" fooBarBaz" + EOL +
"} from '../../../helpers/foo/bar-baz';"
"} from '../../../../helpers/foo/bar-baz';"
});
});
});
Expand Down Expand Up @@ -427,7 +427,7 @@ describe('Acceptance: ember generate in-repo-addon', function() {
});
assertFile('lib/my-addon/app/initializers/foo.js', {
contains: [
"export { default } from 'my-addon/initializers/foo';"
"export { default, initialize } from 'my-addon/initializers/foo';"
]
});
assertFile('tests/unit/initializers/foo-test.js');
Expand All @@ -448,7 +448,7 @@ describe('Acceptance: ember generate in-repo-addon', function() {
});
assertFile('lib/my-addon/app/initializers/foo/bar.js', {
contains: [
"export { default } from 'my-addon/initializers/foo/bar';"
"export { default, initialize } from 'my-addon/initializers/foo/bar';"
]
});
assertFile('tests/unit/initializers/foo/bar-test.js');
Expand Down
4 changes: 2 additions & 2 deletions tests/acceptance/pods-generate-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,7 @@ describe('Acceptance: ember generate pod', function() {
assertFile('tests/unit/helpers/foo/bar-baz-test.js', {
contains: "import {" + EOL +
" fooBarBaz" + EOL +
"} from '../../../helpers/foo/bar-baz';"
"} from '../../../../helpers/foo/bar-baz';"
});
});
});
Expand All @@ -388,7 +388,7 @@ describe('Acceptance: ember generate pod', function() {
assertFile('tests/unit/helpers/foo/bar-baz-test.js', {
contains: "import {" + EOL +
" fooBarBaz" + EOL +
"} from '../../../helpers/foo/bar-baz';"
"} from '../../../../helpers/foo/bar-baz';"
});
});
});
Expand Down

0 comments on commit 792075d

Please sign in to comment.