Merge pull request #10172 from bertdeblock/optimize-require-statements

[PERFORMANCE] Lazy require heavier packages
ember-cli · Feb 11, 2023 · 9644ac0 · 9644ac0
2 parents 690ed75 + 4cbd925
commit 9644ac0
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 9 deletions.
diff --git a/lib/commands/test.js b/lib/commands/test.js
@@ -10,8 +10,6 @@ const fs = require('fs');
 const temp = require('temp');
 temp.track();
 
-require('express').static.mime.define({ 'application/wasm': ['wasm'] });
-
 let defaultPort = 7357;
 
 module.exports = Command.extend({
@@ -81,6 +79,9 @@ module.exports = Command.extend({
   init() {
     this._super.apply(this, arguments);
 
+    // Make sure Testem supports the Wasm MIME type:
+    require('express').static.mime.define({ 'application/wasm': ['wasm'] });
+
     this.Builder = this.Builder || Builder;
     this.Watcher = this.Watcher || Watcher;
 

diff --git a/lib/models/blueprint.js b/lib/models/blueprint.js
@@ -23,7 +23,6 @@ const EOL = require('os').EOL;
 const bowEpParser = require('bower-endpoint-parser');
 const logger = require('heimdalljs-logger')('ember-cli:blueprint');
 const normalizeEntityName = require('ember-cli-normalize-entity-name');
-const { removeTypes } = require('remove-types');
 const isAddon = require('../utilities/is-addon');
 const { deprecate } = require('../debug');
 
@@ -532,6 +531,7 @@ let Blueprint = CoreObject.extend({
   async convertToJS(fileInfo) {
     let rendered = await fileInfo.render();
 
+    const { removeTypes } = require('remove-types');
     const transformed = await removeTypes(rendered);
 
     fileInfo.rendered = transformed;

diff --git a/lib/tasks/interactive-new.js b/lib/tasks/interactive-new.js
@@ -1,16 +1,14 @@
 'use strict';
 
-const inquirer = require('inquirer');
-const { isLangCode } = require('is-language-code');
-const osLocale = require('os-locale');
-
 const Task = require('../models/task');
 const isValidProjectName = require('../utilities/valid-project-name');
 
 const DEFAULT_LOCALE = 'en-US';
 
 class InteractiveNewTask extends Task {
   async run(newCommandOptions, _testAnswers) {
+    const inquirer = require('inquirer');
+
     let prompt = inquirer.createPromptModule();
     let questions = await this.getQuestions(newCommandOptions);
     let answers = await prompt(questions, _testAnswers);
@@ -24,6 +22,8 @@ class InteractiveNewTask extends Task {
   }
 
   async getQuestions(newCommandOptions = {}) {
+    const { isLangCode } = require('is-language-code');
+
     return [
       {
         name: 'blueprint',
@@ -145,6 +145,8 @@ class InteractiveNewTask extends Task {
   }
 
   getUserLocale() {
+    const osLocale = require('os-locale');
+
     return osLocale();
   }
 }

diff --git a/lib/tasks/transforms/amd/index.js b/lib/tasks/transforms/amd/index.js
@@ -1,7 +1,5 @@
 'use strict';
 
-const shimAmd = require('./amd-shim');
-
 class AmdTransformAddon {
   /**
    * This addon is used to register a custom AMD transform for app and addons to use.
@@ -15,6 +13,8 @@ class AmdTransformAddon {
   }
 
   importTransforms() {
+    const shimAmd = require('./amd-shim');
+
     return {
       amd: {
         transform: (tree, options) => {