-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
/tests
might conflict with app routes.
#167
Comments
Yah, don't care :) I'm totally against naming it |
homu
added a commit
that referenced
this issue
Sep 28, 2016
…=nathanhammond Update chai-as-promised to version 6.0.0 🚀 Hello lovely humans, [chai-as-promised](https://www.npmjs.com/package/chai-as-promised) just published its new version 6.0.0. <table> <tr> <th align=left> State </th> <td> Update 🚀 </td> </tr> <tr> <th align=left> Dependency </td> <td> chai-as-promised </td> </tr> <tr> <th align=left> New version </td> <td> 6.0.0 </td> </tr> <tr> <th align=left> Type </td> <td> devDependency </td> </tr> </table> This version is **not covered** by your **current version range**. Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though. I recommend you look into these changes and try to get onto the latest version of chai-as-promised. Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update. Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right? Are you unsure about how things are supposed to work? There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html) and while I’m just a bot, there is a group of people who are happy to teach me new things. [Let them know](https://github.com/greenkeeperio/greenkeeper/issues/new). Good luck with your project ✨ You rock! 🌴 --- [GitHub Release](https://github.com/domenic/chai-as-promised/releases/tag/v6.0.0) <p>In <a href="https://urls.greenkeeper.io/domenic/chai-as-promised/pull/167" class="issue-link js-issue-link" data-url="chaijs/chai-as-promised#167" data-id="177667891" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#167</a>, <a href="https://urls.greenkeeper.io/lddubeau" class="user-mention">@lddubeau</a> made many improvements to edge cases that have plagued users:</p> <ul> <li>Overhauls <code>rejectedWith</code> to behave more like Chai's <code>throws</code> asserter.</li> <li>Updates <code>.fulfilled</code>, <code>.rejected</code>, and <code>.rejectedWith</code> to change the asserter target to the fulfillment value or rejection reason, so that further assertions with <code>.and</code> act on them.</li> <li>Updates <code>.fulfilled</code>, when successful, to return a promise that fulfills with the fulfillment value</li> <li>Updates <code>.rejected</code> and <code>.rejectedWith</code>, when successful, to return a promise that fulfills with the rejection reason</li> </ul> <p>Also, Chai as Promised now only supplies a CommonJS-style module. To get AMD or <code><script></code>-compatibility, use a bundler tool like <a href="http://browserify.org/">browserify</a>.</p> --- The new version differs by 28 commits . - [`b2cfbdc`](chaijs/chai-as-promised@b2cfbdc) <code>6.0.0</code> - [`479f867`](chaijs/chai-as-promised@479f867) <code>Update copyright year</code> - [`bb51e07`](chaijs/chai-as-promised@bb51e07) <code>Switch to pure CommonJS</code> - [`fc9f868`](chaijs/chai-as-promised@fc9f868) <code>Load check-error in the browser too</code> - [`33ce9df`](chaijs/chai-as-promised@33ce9df) <code>Bring promise rejection tests in line with Chai.</code> - [`10beb9e`](chaijs/chai-as-promised@10beb9e) <code>Harmonize error messages with those of Chai</code> - [`a8b88d0`](chaijs/chai-as-promised@a8b88d0) <code>Fix the .not.rejectedWith tests</code> - [`1f7fc93`](chaijs/chai-as-promised@1f7fc93) <code>Use check-error to get expected constructor name</code> - [`e425136`](chaijs/chai-as-promised@e425136) <code>Redesign UMD code to allow imports</code> - [`823c15b`](chaijs/chai-as-promised@823c15b) <code>Allow chaining tests and promises.</code> - [`52beb1f`](chaijs/chai-as-promised@52beb1f) <code>Add a notMessage option</code> - [`40fe94e`](chaijs/chai-as-promised@40fe94e) <code>Restructure to avoid so much nesting</code> - [`62e137f`](chaijs/chai-as-promised@62e137f) <code>Add test cases that reproduce issue #113</code> - [`7662aca`](chaijs/chai-as-promised@7662aca) <code>Add a case that replicates issue #64</code> - [`deb505c`](chaijs/chai-as-promised@deb505c) <code>Add test cases to cover issue #47</code> There are 28 commits in total. See the [full diff](chaijs/chai-as-promised@5f20e6c...b2cfbdc). --- This pull request was created by [greenkeeper.io](https://greenkeeper.io/). <sub>Tired of seeing this sponsor message? ⚡ `greenkeeper upgrade`</sub>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We expose tests through
/tests
, if someone has a route calledtests
and they are using history location then we'll break their app ;(.The text was updated successfully, but these errors were encountered: