Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.13.12 - Windows - The browser loading indicator keeps spinning #5123

Closed
HerveSeger opened this issue Nov 18, 2015 · 14 comments
Closed

v1.13.12 - Windows - The browser loading indicator keeps spinning #5123

HerveSeger opened this issue Nov 18, 2015 · 14 comments
Labels

Comments

@HerveSeger
Copy link

I just upgraded from 1.13.8 to 1.13.12 on Windows 7 Enterprise (x64) and everything went well.
node/npm: 0.12.7/2.11.3.

When I run my app after the upgrade everything is ok except one little thing: the tab spinner keeps, well, spinning, forever. The application is ok, there is no error in the console. response times are normal, just this very annoying spinner that never stops.

Chrome/Firefox behave the same way.

In order to make sure that the problem did not come from one of my app package, I have created a brand new app and I face the same issue.

I have rolled back to 1.13.8 for now.

@stefanpenner
Copy link
Contributor

I'm going to assume live reload also doesn't work?

My guess is something is sideways with livery load WS connection. Maybe a restricted port? My Windows unfortunately does not replicate this.

Does a fresh app have the same issue?

@HerveSeger
Copy link
Author

Yes a fresh app created with ember new app had the same problem but thank you for the note on live reload because it looks that it is indeed a port issue, see below.

I noticed that the port number used by live reload was different between 1.13.8 (49155) and 1.13.12 (49152) so I restarted the test app with ember serve -lrp 49155) and it worked.

By using the cmd netstat -a I can see that indeed 49152 is already used by another process.

I am going to resume the upgrade of my production app to 1.13.12 but I close this issue.

Thanks a lot for the help.

@stefanpenner
Copy link
Contributor

our system should be choosing open ports

@stefanpenner
Copy link
Contributor

short term:

  • figure out whats up with our port detection code.

long term solution:

  • live-reload should just be multi-plexed over the existing HTTP port

@stefanpenner
Copy link
Contributor

for reference, we use:

portfinder over here

@Kilowhisky
Copy link

This is the same that is happening here. #5101

@gmurphey
Copy link
Contributor

It seems like this may have something to do with removing the default for host in this commit: f5da211

There is an issue (feature) with Portfinder when host is not set explicitly: http-party/node-portfinder#13

A remedy, until this can be fixed, may be to run ember serve --host <host>. I don't have my Windows machine in front of me right now to test this.

@gmurphey
Copy link
Contributor

It worked out of the box on my Windows machine, but I was able to get it to break and confirm my guess above. Steps to reproduce this bug:

  1. Find a range of ports being used by 0.0.0.0 using netstat (49408-49411 on my machine)
  2. Change PortFinder.basePort to the start of that range in the serve command (49408 for me)
  3. Run ember serve and see the livereload request pending (livereload started on 49410, a port already in use on my machine)
  4. Run ember serve --host 0.0.0.0 and livereload should work

@HaulinOats
Copy link

ember serve --host 0.0.0.0 has fixed the problem for me for now. Before it was constantly showing loading gif and "waiting for localhost..." at the bottom of the screen. Thank you!

@jackmatt2
Copy link
Contributor

I was getting this behaviour after upgrading to 1.13.13 on Windows 7 64bit also. The ember serve --host 0.0.0.0 fixed it for me for now.

@jackmatt2
Copy link
Contributor

Actually, the above stopped the spinner but live reload does not work. I was experiencing this back in 1.13.8 also but just put up with it and manually had to reload the page.

Using something like ember serve -lrp 9000 has solved the issue and it is reloading automatically again.

@adam-knights
Copy link

Is there an eta for a 1.13 fix for this? Trying to decide whether to get our team using 1.13.13 for the speed improvements and get them running the workaround, or whether to wait for a fix if its imminent..

@jackmatt2
Copy link
Contributor

@adam-knights I would suggest upgrading for windows users. Previously my laptop was running extremely hot when running ember-cli on windows. Now after the upgrade, my laptop is running cool again. It is as simple as adding a serve.bat file with the command above in it.

@gmurphey
Copy link
Contributor

Thinking this will be fixed by #5354.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants