Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --no-welcome option or similar to new & init #6444

Closed
courajs opened this issue Nov 21, 2016 · 3 comments
Closed

Add --no-welcome option or similar to new & init #6444

courajs opened this issue Nov 21, 2016 · 3 comments
Labels
enhancement good first issue

Comments

@courajs
Copy link
Contributor

courajs commented Nov 21, 2016

While ember-welcome-page is great for first experience, the first thing I do after generating a new app is remove it. It would be nice to be able to not install it in the first place.
@nathanhammond
Copy link
Contributor

@courajs Would you be willing to open a PR for this? It's something we would certainly entertain. Bonus points if you make it generically applicable to any dependency in the app's package.json file.

@courajs
Copy link
Contributor Author

courajs commented Nov 28, 2016

Happy to pick it up when I've got some free time!

@romulomachado romulomachado mentioned this issue Mar 18, 2017
Merged
@romulomachado
Copy link
Contributor

@Turbo87 @nathanhammond I sent #6868, but it's not fully implemented. I need some help.

The way I thought to solve this was updating the blueprint to not have the ember-welcome-page dependency and {{welcome-page}} on application.hbs. If --skip-welcome isn't set, they'd be inserted back.

I tried using insertIntoFile with no success. Any tips on how to move forward?

homu added a commit that referenced this issue Apr 25, 2017
@homu
Auto merge of #6868 - romulomachado:add-skip-welcome-page-option, r=r…
c0028fe 
…wjblue

Add --welcome option to `new` and `init` so that it can be skipped with --no-welcome

Closes #6444
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@stefanpenner @nathanhammond @Turbo87 @romulomachado @courajs